Fix Claude review steps in ClauDependabot workflow#22
Open
danielorbach wants to merge 2 commits intomainfrom
Open
Fix Claude review steps in ClauDependabot workflow#22danielorbach wants to merge 2 commits intomainfrom
danielorbach wants to merge 2 commits intomainfrom
Conversation
In agent mode, claude-code-action does not include default file-reading tools; only the tools listed in claude_args are available. Without Read, Glob, and Grep, Claude spent all turns hitting permission denials and never posted its review comment.
v1.0.65 of claude-code-action changed the display_report default from true to false (PR #992), and v1.0.66 stripped detailed permission_denials from the sanitized output (PR #993). Both changes protect against prompt injection when Claude is triggered by untrusted input (e.g. public issue comments) that could produce malicious markdown in the Step Summary. This workflow only triggers on Dependabot PRs (a trusted actor with controlled input), so the prompt injection threat model does not apply. Re-enabling display_report restores the workflow summary report for reviewing Claude's analysis.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR modifies the GitHub Actions workflow configuration to augment Claude's review capabilities by enabling report output and adding tool allowances. Specifically, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClauDependabot workflow's Claude review steps were silently failing: Claude ran 13 turns with 11 permission denials and never posted its review comment (run #23004309970).
Two issues, both caused by differences between this workflow and the working one in
go-digitaltwin/go-digitaltwin:Missing file-reading tools. This workflow added
actions/checkoutso Claude could read local files, but in agent modeclaude-code-actiondoes not inject default tools (unlike tag mode which includesRead,Glob,Grep, etc.). TheallowedToolswhitelist only hadBash(gh ...)patterns, so every attempt to read the checkout was denied.No workflow summary report.
claude-code-actionv1.0.65 changeddisplay_reportdefault tofalse, and v1.0.66 stripped detailedpermission_denialsfrom sanitized output (both in PR #992 and PR #993). These changes protect against prompt injection from untrusted input rendered in the Step Summary. Since this workflow only triggers on Dependabot PRs (trusted actor, controlled input), the threat model does not apply;display_reportis re-enabled explicitly.